#307 Update board/README.md for MacOs instructions and move ./get_sdk… #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get_sdk_mac.sh pycrypto to --user space
|
@jayproulx , just realized those scripts were still on python2: |
rbiasini
reviewed
Oct 29, 2019
| @@ -4,6 +4,7 @@ Dependencies | |||
| **Mac** | |||
|
|
|||
| ``` | |||
| xcode-select --install | |||
rbiasini
reviewed
Oct 29, 2019
| @@ -2,4 +2,5 @@ | |||
| # Need formula for gcc | |||
| brew tap ArmMbed/homebrew-formulae | |||
| brew install python dfu-util arm-none-eabi-gcc | |||
| pip2 install libusb1 pycrypto requests | |||
| pip2 install libusb1 requests | |||
| pip2 install --user pycrypto | |||
There was a problem hiding this comment.
I think for mac we should install everything with --user. If you make the change I'll merge it.
|
fixed in 256d274 |
|
@rbiasini You beat me to it! Halloween got in the way :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors while running ./board/get_sdk_mac.sh were twofold: